test: cover nonstream upstream failed response shape#7
Merged
Conversation
HisenWeb
marked this pull request as ready for review
June 24, 2026 23:18
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds P1-3 regression coverage for non-stream upstream HTTP errors.
After inspection, the runtime already returns a Responses-shaped body with
status: failedfor non-stream/v1/responsesupstream failures. This PR therefore locks the behavior with a focused regression test instead of changing runtime code.Changes
tests/nonstream_upstream_error_regression.rs.object: responsestatus: failedoutputusageerror.type/code: upstream_errordocs/p1-nonstream-upstream-error.mddocumenting the current behavior and the future HTTP-200 policy option if real Codex validation requires it.Current policy
The adapter currently preserves the upstream HTTP status while returning a Responses
failedbody. If real Codex subagent validation shows that non-2xx status still breaks the chain, the next policy change should be explicit: return HTTP 200 withresponse.status = failedfor/v1/responsesupstream errors.Validation
Edited via GitHub connector. Please run locally before merge:
Notes
This PR intentionally does not change
/v1/modelsupstream error behavior.